Skip to content

Fix indentation for 'pack' and 'extensible' fields in model YAML files#146

Merged
felickz merged 2 commits intomainfrom
fix-model-format
Apr 7, 2026
Merged

Fix indentation for 'pack' and 'extensible' fields in model YAML files#146
felickz merged 2 commits intomainfrom
fix-model-format

Conversation

@felickz
Copy link
Copy Markdown
Contributor

@felickz felickz commented Apr 2, 2026

Fixing error when running with model packs enabled in IDE with CodeQL extension:

BROKEN (original)

- addsTo:
  pack: codeql/python-all
  extensible: sourceModel
  data:

FIXED

- addsTo:
    pack: codeql/python-all
    extensible: sourceModel
  data:

Copilot AI review requested due to automatic review settings April 2, 2026 16:22
Copilot AI reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@felickz
Copy link
Copy Markdown
Contributor Author

felickz commented Apr 7, 2026

@copilot fix the failing CI (https://github.com/GitHubSecurityLab/CodeQL-Community-Packs/actions/runs/23910574560/job/69732704622?pr=146) for this PR

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

@copilot fix the failing CI (https://github.com/GitHubSecurityLab/CodeQL-Community-Packs/actions/runs/23910574560/job/69732704622?pr=146) for this PR

Fixed in f7cabe5.

Root cause: actions/download-artifact@v5 (current version on main) creates a different directory structure than @v6 (used in the December dependabot PR #143 that passed CI). The glob *-test-results/test_report_* in the validate step expands correctly with @v6 but silently fails with @v5, causing jq to receive the literal glob string as a filename. The December run worked because it was running against the dependabot branch's ci.yml which had already upgraded to @v6.

The fix replaces the glob pattern with find-based file discovery (which works regardless of action version), and also fixes the broken jq command quoting in the for loop.

felickz
felickz commented Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@felickz felickz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: 👍

@felickz felickz merged commit 2d9e55d into main Apr 7, 2026
21 checks passed
@felickz felickz deleted the fix-model-format branch April 7, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felickz